change CASE_ENKF to CASE_ANL in UFO testing script#411
Merged
Conversation
Contributor
Author
|
I should note that the UFO tests don't actually need this variable (there is no analysis resolution) but the YAML generation code requires it (that should probably be also fixed later) |
RussTreadon-NOAA
approved these changes
Apr 6, 2023
Contributor
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Sorry for not catching this in my PR from earlier in the week. Change is correct.
Approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#405 changed the scripts that compute the analysis resolution for the YAML files from
CASE_ENKFtoCASE_ANL.The UFO driver testing scripts (such as what produce https://emc.ncep.noaa.gov/data_assimilation/JEDI/GDAS/UFO/acceptance/) need to also be updated to define these variables in its environment, otherwise it will fail.
This PR makes that change for ush/ufoeval/run_ufo_hofx_test.sh