Add 3denvar option to run_jedi_exe.py#405
Conversation
|
Automated Global-Workflow GDASApp Testing Results: |
|
Automated Global-Workflow GDASApp Testing Results: |
kevindougherty-noaa
left a comment
There was a problem hiding this comment.
Just a couple of quick remarks. I will take a more in-depth look first thing Monday.
|
Rebuilt GDASApp 3/27 evening. Much to my surprise 3dvar and 3denvar jobs launched by The GDASApp build clones the head of gsibec develop. I reached out to Ricardo Todling (GMAO). He advised that we use the gsibec hash referenced in saber. This is gsibec tag 1.0.7. Update GDASApp top level Rebuilt GDASApp. The 3dvar and 3denvar tests successfully ran to completion with gsibec tag 1.0.7. Commit this change |
|
Thanks @RussTreadon-NOAA for all the hard work on this and the back and forth in review, much appreciated! |
|
Will wait either for a 2nd approval or confirmation about the RT results being as expected before merging |
|
Automated Global-Workflow GDASApp Testing Results: |
|
Automated Global-Workflow GDASApp Testing Results: |
|
These two single test failures are expected given earlier discussion with @RussTreadon-NOAA , I will merge this PR in and hope that the g-w PR can be merged relatively soon. |
|
The Hera and Orion GW-RT failures of This PR removes g-w |
|
Sorry @RussTreadon-NOAA if I jumped the gun on merging this. Let me try to review NOAA-EMC/global-workflow#1373 later today and see if we can get the ball rolling on that. |
* extend run_jedi_exe.py to launch 3denvar (#402) * set comin_ges for 3denvar based on machine (#402) * correct gsibec case logic, replace print with logger (#402) * move import genYAML in run_jedi_exe.py (#402) * clone gsibec tag 1.0.7 instead of gsibec develop (#402) * replace surface_geometric_height with surface_geopotential_height in sondes.yaml (#402) * replace CASE_ENKF with CASE_ANL in ush/ufsda scripts (#402) * replace CASE_ENKF with CASE_ANL in genYAML test driver scripts (#402) * set 4dhofx config to 1 task per node; remove unused keywords from letkf config (#402) * remove references to comin_ges and cominges (#402) * simplify logic to stage staticb (#402) * consolidate staging of ensemble backgrounds for EnVar and LETKF (#402) * correct pynorm errors in stage.py (#402) * clean up stage.py scripting and comments (#402)
The changes in this PR add the option to launch
fv3jedi_var.xin 3denvar mode viaush/run_jedi_exe.py. This functionality is useful since operational GSI-based global and regional DA systems run in a hybrid model in which the static background error is augmented with an ensemble component (envar).This PR adds four new files:
parm/atm/berror/hybvar_gsibec.yaml- hybrid background error yaml file usinggsibecfor static-B along with a 10 member ensembletest/atm/run_jedi_exe_3denvar.sh- ctest usingrun_jedi_exe.pyto launchfv3jedi_var.xin 3denvar modeush/examples/run_jedi_exe/3denvar_hera.yaml- configuration file used byrun_jedi_exe.pyto run 3denvar sample case on Heraush/examples/run_jedi_exe/3denvar_orion.yaml- configuration file used byrun_jedi_exe.pyto run 3denvar sample case on OrionEleven existing files are modified:
CMakeLists.txt- update gsibec to tag 1.0.7. Previously pointed at head of gsibec develop. This is problematic since the head of gsibec develop is not always function and/or requires specific hashes of other JEDI components.parm/atm/obs/config/sondes.yaml- replacesurface_geometric_heightwithsurface_geopotential_heightto avoidfv3jedi_var.xsegmentation faulttest/atm/CMakeLists.txt- addtest_gdasapp_run_jedi_exe_3denvartest/genYAML_prep.sh- replaceCASE_ENKFwithCASE_ANLtest/genYAML_prep_aero.sh- replaceCASE_ENKFwithCASE_ANLtest/genYAML_prep_land.sh- replaceCASE_ENKFwithCASE_ANLush/run_jedi_exe.py- removeatmosfrom enkfgdas root path. This change is necessitate by changes in the g-w GFS directory structure. Theatmosdirectory is now located inmemXXXdirectories.ush/ufsda/genYAML.py- replaceCASE_ENKFwithCASE_ANLush/ufsda/misc_utils.py- replaceCASE_ENKFwithCASE_ANLush/ufsda/stage.py- addatmosto thememXXXpath for ensemble members, enhance error checking fordohybvar = .true.option, add logic to ensure correctgsibecstatic-B is linked to the run directory.ush/ufsda/ufs_yaml.py- replaceCASE_ENKFwithCASE_ANLFixes #402