break out ens and parametric bkgerr stats#1922
Merged
Merged
Conversation
AndrewEichmann-NOAA
requested review from
DavidNew-NOAA,
Copilot and
guillaumevernieres
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
Separates ensemble and parametric background error statistics handling to prevent scrambling of these different error types in the marine background matrix save configuration.
- Moves parametric background error files outside the conditional block
- Keeps ensemble background error files within the hybrid/ensemble conditional block
- Ensures proper file naming and organization for different error statistics types
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
DavidNew-NOAA
previously approved these changes
Oct 1, 2025
guillaumevernieres
previously approved these changes
Oct 1, 2025
Contributor
guillaumevernieres
left a comment
guillaumevernieres
left a comment
There was a problem hiding this comment.
Thanks @AndrewEichmann-NOAA , can you check if something needs to be done on the archiving side.
Collaborator
Author
|
@guillaumevernieres It does, testing that now |
22 tasks
AndrewEichmann-NOAA
added
hercules-GW-RT
emcbot
added
ursa-GW-RT-Running
hercules-GW-RT-Running
AndrewEichmann-NOAA
dismissed stale reviews from guillaumevernieres and DavidNew-NOAA
via
f7cc00d
|
Automated GW-GDASApp Testing Results: |
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hercules-GW-RT-Failed
AndrewEichmann-NOAA
added
hercules-GW-RT
emcbot
added
hercules-GW-RT-Running
|
Automated GW-GDASApp Testing Results: |
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hercules-GW-RT-Passed
AndrewEichmann-NOAA
requested review from
DavidNew-NOAA and
guillaumevernieres
Merged
7 tasks
guillaumevernieres
pushed a commit
that referenced
this pull request
Oct 2, 2025
# Description Update jcb-gdas hash # Companion PRs NA # Issues Cleanup of merge of #1922 # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !--> - [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !--> - [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
Contributor
|
@AndrewEichmann-NOAA and @guillaumevernieres : After merging this PR into Do we need to run ctests using g-w branch |
Collaborator
Author
@RussTreadon-NOAA Yes. Is there a way I should indicate that? |
Contributor
|
@AndrewEichmann-NOAA . You note this requirement above.
The problem is that automated |
DavidNew-NOAA
pushed a commit
that referenced
this pull request
Jan 16, 2026
# Description Fixes scrambling of ens and parametric bkgerr stats # Companion PRs Requires NOAA-EMC/jcb-gdas#186 and pending g-w PR (NOAA-EMC/global-workflow#4120) <!-- Enter links to any companion PRs here. --> # Issues Resolves, with jcb-gdas and global-workflow PRs, #1921 # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !--> - [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !--> - [x] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !--> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
DavidNew-NOAA
pushed a commit
that referenced
this pull request
Jan 16, 2026
# Description Update jcb-gdas hash # Companion PRs NA # Issues Cleanup of merge of #1922 # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !--> - [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !--> - [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes scrambling of ens and parametric bkgerr stats
Companion PRs
Requires NOAA-EMC/jcb-gdas#186 and pending g-w PR (NOAA-EMC/global-workflow#4120)
Issues
Resolves, with jcb-gdas and global-workflow PRs, #1921
Automated CI tests to run in Global Workflow