Fix bug for marine ecen#1820
Merged
Merged
Conversation
RussTreadon-NOAA
approved these changes
Jul 28, 2025
Contributor
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Assuming we always recenter using files from enkfgdas this is the correct change.
Approve pending confirmation that this is indeed the desired behavior.
Collaborator
Author
|
@RussTreadon-NOAA Yes, this is indeed what the marine_recenter.py script was doing before on initialization. See GDASApp/ush/soca/marine_recenter.py Line 163 in fe98bc4 For whatever reason, changed this to |
DavidNew-NOAA
added a commit
that referenced
this pull request
Jan 16, 2026
# Description Quick bug fix based on NOAA-EMC/global-workflow#3882 (comment) # Companion PRs NOAA-EMC/global-workflow#3882 # Issues <!-- Enter any issues referenced or resolved by this PR here. Use keywords "Resolves" or "Refs". Resolves #1234 Refs #4321 Refs NOAA-EMC/repo#5678 --> # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !--> - [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !--> - [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quick bug fix based on NOAA-EMC/global-workflow#3882 (comment)
Companion PRs
NOAA-EMC/global-workflow#3882
Issues
Automated CI tests to run in Global Workflow