Skip to content

add ctest to create yaml for lgetkf observer ctest#1272

Merged
RussTreadon-NOAA merged 1 commit into
NOAA-EMC:developfrom
RussTreadon-NOAA:feature/lgetkf_ctests_init
Sep 3, 2024
Merged

add ctest to create yaml for lgetkf observer ctest#1272
RussTreadon-NOAA merged 1 commit into
NOAA-EMC:developfrom
RussTreadon-NOAA:feature/lgetkf_ctests_init

Conversation

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Sep 3, 2024

This PR adds ctest test_gdasapp_atm_jjob_ens_init_split to the atm_jjob suite of ctests. Test test_gdasapp_atm_jjob_ens_init_split creates the yaml file used by test_gdasapp_atm_jjob_ens_obs - the observer lgetkf ctest.

Resolves #1271

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Sep 3, 2024
@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

RussTreadon-NOAA commented Sep 3, 2024

Notes:

  1. The changes in this PR must be tested with g-w PR #2805. The JEDI class changes in #2805 necessitate the changes in this GDASApp PR.
  2. At a later date the GDASApp team may decide to remove the combined lgetkf ctest, test_gdasapp_atm_jjob_ens_letkf. If this is done new issues and PRs will be opened in multiple repositories to remove the combined lgetkf option.

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

RussTreadon-NOAA commented Sep 3, 2024

@DavidNew-NOAA, @CoryMartin-NOAA , and @TravisElless-NOAA : here's the PR to update GDASApp ctests so that we can run both the combined and split lgetkf tests with g-w PR #2805. Without this PR, test_gdasapp_atm_jjob_ens_obs and test_gdasapp_atm_jjob_ens_sol will fail after g-w PR #2805 enters g-w develop.

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

RussTreadon-NOAA commented Sep 3, 2024

Thank you @CoryMartin-NOAA for the review & approval.

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

CoryMartin-NOAA commented Sep 3, 2024

@RussTreadon-NOAA merge when you're satisfied. We do not need this hash in the g-w PR, right? We just need to accept that tests will fail in GDASApp between the g-w merge and this merge. Is there any harm in this merging early?

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

RussTreadon-NOAA commented Sep 3, 2024

@CoryMartin-NOAA , you are correct. We can merge this PR into GDASApp develop right now. Doing so will break a few ctests.
These failures will go away after JEDI class is in g-w. I'll go ahead and merge this PR into develop.

@RussTreadon-NOAA RussTreadon-NOAA merged commit faa95ef into NOAA-EMC:develop Sep 3, 2024
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/lgetkf_ctests_init branch September 3, 2024 19:44
DavidHuber-NOAA added a commit to DavidHuber-NOAA/GDASApp that referenced this pull request Sep 9, 2024
@DavidHuber-NOAA
Merge remote-tracking branch 'origin/develop' into feature/ss_180
10edded 
* origin/develop:
  Turn on OMA diagnostics after JEDI minimization (NOAA-EMC#1274)
  Adding AHI and SEVIRI satwnd thinning, enrolling AHI-H9, SEVIRI-M9, SEVIRI-M10 (NOAA-EMC#1263)
  add ctest to create yaml for lgetkf observer ctest (NOAA-EMC#1272)
  add soca fix yaml file for 1deg (NOAA-EMC#1270)
  Fix to marine post and archiving (NOAA-EMC#1266)
  Add JPSSRR sea-ice product to ioda converter (NOAA-EMC#1259)
  enable atmospheric lgetkf ctests to run in combined and split modes (NOAA-EMC#1262)
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@RussTreadon-NOAA
add ctest to create yaml for lgetkf observer ctest (#1272)
d60ae89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@DavidNew-NOAA DavidNew-NOAA Awaiting requested review from DavidNew-NOAA

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update lgetkf ctests for g-w jedi class

2 participants

@RussTreadon-NOAA @CoryMartin-NOAA