enable atmospheric lgetkf ctests to run in combined and split modes#1262
Merged
RussTreadon-NOAA merged 2 commits intoAug 26, 2024
Merged
Conversation
Contributor
Author
|
@TravisElless-NOAA and @CoryMartin-NOAA , this PR is necessary once g-w PR #2833 is merged into g-w g-w PR #2833 creates the yaml(s) required by the mode in which lgetkf is run. We do this by checking the value of logical When this logical is The same approach is used for JEDI-based DA. When the logical is I retained both the combined observer+solver and separate observe & solver ctests in GDASApp. This is problematic because |
Contributor
Author
|
Hera tests Install Run g-w CI for C96C48_hybatmDA, C96C48_ufs_hybatmDA, C96C48_hybatmaerosnowDA, and C48mx500_3DVarAOWCDA. All jobs in all cycles of each CI configuration successfully run to completion C96C48_hybatmDA C96C48_ufs_hybatmDA C96C48_hybatmaerosnowDA C48mx500_3DVarAOWCDA |
Contributor
Author
|
The |
Contributor
|
@RussTreadon-NOAA would there ever be a scenario where these test get flipped around that would require the |
Contributor
Author
|
Very good point @TravisElless-NOAA. All three ctests (letkf, obs, sol) now contain a Reran ctest using |
TravisElless-NOAA
approved these changes
Aug 26, 2024
Contributor
TravisElless-NOAA
left a comment
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
Things look good to me. Thanks @RussTreadon-NOAA
Contributor
Author
|
Thank you @TravisElless-NOAA for your review and approval. |
DavidHuber-NOAA
added a commit
to DavidHuber-NOAA/GDASApp
that referenced
this pull request
Sep 9, 2024
* origin/develop: Turn on OMA diagnostics after JEDI minimization (NOAA-EMC#1274) Adding AHI and SEVIRI satwnd thinning, enrolling AHI-H9, SEVIRI-M9, SEVIRI-M10 (NOAA-EMC#1263) add ctest to create yaml for lgetkf observer ctest (NOAA-EMC#1272) add soca fix yaml file for 1deg (NOAA-EMC#1270) Fix to marine post and archiving (NOAA-EMC#1266) Add JPSSRR sea-ice product to ioda converter (NOAA-EMC#1259) enable atmospheric lgetkf ctests to run in combined and split modes (NOAA-EMC#1262)
DavidNew-NOAA
pushed a commit
that referenced
this pull request
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generalizes the atmospheric lgetkf ctests to support the following ctests
test_gdasapp_atm_jjob_ens_letkf- run lgetkf with observer and solvertest_gdasapp_atm_jjob_ens_obs- run lgetkf in observer mode onlytest_gdasapp_atm_jjob_ens_sol- run lgetkf in solver mode onlyThese changes are necessitated by changes in g-w PR #2833.
Resolves #1261