Skip to content

More marine DA bufixes #1069

Merged
guillaumevernieres merged 2 commits into
developfrom
bugfix/cyc-oceanmask
Apr 23, 2024
Merged

More marine DA bufixes #1069
guillaumevernieres merged 2 commits into
developfrom
bugfix/cyc-oceanmask

Conversation

@guillaumevernieres
Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres commented Apr 22, 2024

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 22, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 23, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 23, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Tue Apr 23 00:09:33 UTC 2024 on hfe04
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Apr 23 00:57:37 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Tue Apr 23 01:12:26 UTC 2024
Tests: 93% tests passed, 3 tests failed out of 45
	1767 - test_gdasapp_atm_jjob_var_run (Failed)
	1768 - test_gdasapp_atm_jjob_var_inc (Failed)
	1769 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1069/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Apr 23, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 23, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Mon Apr 22 19:05:29 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Apr 22 19:54:40 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Apr 22 20:13:26 CDT 2024
Tests: 93% tests passed, 3 tests failed out of 45
	1768 - test_gdasapp_atm_jjob_var_run (Failed)
	1769 - test_gdasapp_atm_jjob_var_inc (Failed)
	1770 - test_gdasapp_atm_jjob_var_final (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1069/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Apr 23, 2024
AndrewEichmann-NOAA
AndrewEichmann-NOAA approved these changes Apr 23, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@guillaumevernieres guillaumevernieres merged commit c54bf6d into develop Apr 23, 2024
@guillaumevernieres guillaumevernieres deleted the bugfix/cyc-oceanmask branch April 23, 2024 13:40
danholdaway added a commit that referenced this pull request Apr 23, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
b0591dd 
* upstream/develop:
  More marine DA bufixes  (#1069)
  Add basin flags to the ocean obs (#1067)
  Revert "Prepare observations for snow DA updates to the ensemble members" (#1066)
  Fix aero_diagb template (#1064)
  Refactoring prepocnobs task (#1049)
  Ensemble diagnostics not triggered properly (#1060)
  New ocean/ice B diag (#1050)
  Remove R2D2 and SOLO from the GitHub Actions workflow CI (#1058)
  Variance Partition estimates of Stddev for aerosols (#1037)
  Removing ctests of an obsolete bufr_converter in SOCA (#1056)
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@guillaumevernieres
More marine DA bufixes (#1069)
eaacfbc 
- fixes #1068 
- fixes #1067 
- fixes #985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA approved these changes

@apchoiCMD apchoiCMD apchoiCMD approved these changes

Assignees

No one assigned

Labels

hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Marine obs naming convention is not correct Ocean basin is missing in the obsprep yamls

4 participants

@guillaumevernieres @emcbot @AndrewEichmann-NOAA @apchoiCMD