Variance Partition estimates of Stddev#1037
Merged
Merged
Conversation
andytangborn
requested review from
CoryMartin-NOAA,
guillaumevernieres and
ypwang19
Contributor
CoryMartin-NOAA
left a comment
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
One more thing then I think it's ready to be approved
guillaumevernieres
previously approved these changes
Apr 15, 2024
Contributor
guillaumevernieres
left a comment
guillaumevernieres
left a comment
There was a problem hiding this comment.
Seems good to me. See comments.
Collaborator
Author
|
Not sure what this means. andytangborn dismissed guillaumevernieres’s stale review via 837de5a now |
Contributor
|
it means his previous review is no longer applicable because you updated the branch |
Collaborator
Author
|
I just noticed these lines in chem_diagb.h. These should be removed I think? |
Contributor
|
@andytangborn yes you don't need ssh or sst |
added 2 commits
April 17, 2024 13:16
CoryMartin-NOAA
approved these changes
Apr 17, 2024
Contributor
CoryMartin-NOAA
left a comment
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
Thanks @andytangborn for this, I'll approve and merge, and we can fix any minor issues later when we incorporate it into the workflow. Great work!
danholdaway
added a commit
that referenced
this pull request
Apr 23, 2024
* upstream/develop: More marine DA bufixes (#1069) Add basin flags to the ocean obs (#1067) Revert "Prepare observations for snow DA updates to the ensemble members" (#1066) Fix aero_diagb template (#1064) Refactoring prepocnobs task (#1049) Ensemble diagnostics not triggered properly (#1060) New ocean/ice B diag (#1050) Remove R2D2 and SOLO from the GitHub Actions workflow CI (#1058) Variance Partition estimates of Stddev for aerosols (#1037) Removing ctests of an obsolete bufr_converter in SOCA (#1056)
DavidNew-NOAA
pushed a commit
that referenced
this pull request
Jan 16, 2026
This PR creates code and a yaml (adapted from SOCA) that computes time dependent background error standard deviations using neighboring grid points. These are created "on the fly", eliminating a need for staticB stddev files that need to be switched in or out each season. --------- Co-authored-by: Andrew Tangborn <tangborn@Orion-login-2.HPC.MsState.Edu> Co-authored-by: Cory Martin <cory.r.martin@noaa.gov> Co-authored-by: Andrew Tangborn <tangborn@Orion-login-3.HPC.MsState.Edu> Co-authored-by: Andrew Tangborn <tangborn@Orion-login-4.HPC.MsState.Edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates code and a yaml (adapted from SOCA) that computes time dependent background error standard deviations using neighboring grid points. These are created "on the fly", eliminating a need for staticB stddev files that need to be switched in or out each season.