Unify gfs, cfsr, and gefs datm datamodes#63
Merged
NickSzapiro-NOAA merged 4 commits intoAug 27, 2024
Conversation
Collaborator
Author
|
If datm_datamode_gfs_hafs_mod has been replaced with CDEPS inline functionality and not to be pushed to ESCOMP/CDEPS, maybe this would be a good place to sunset it @binli2337 |
|
@NickSzapiro-NOAA Yes, it is time to remove the gfs_hafs data mode. Thanks! |
binli2337
reviewed
Aug 13, 2024
binli2337
left a comment
binli2337
left a comment
There was a problem hiding this comment.
Looks good. I will approve this PR after the related ufs-weather-model PR is approved. Thanks!
Collaborator
Author
|
Hi @binli2337 , Jun reviewed and approved the ufs-weather-model PR |
|
@binli2337 following up here. Are you able to review this PR? |
|
@binli2337 this PR is ready for final review. |
jkbk2004
approved these changes
Aug 27, 2024
Collaborator
|
looks like I don't have permission to merge. @DeniseWorthen @binli2337 can you merge this pr? |
Collaborator
Author
|
@jkbk2004 merged into cdeps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Code for gfs, cfsr, and gefs datm datamodes is very similar (just with different function names). This PR removes the duplicates. As gefs datm datamode is already in ESCOMP/CDEPS, gefs is retained here. Note that GFS, GEFS, CFSR, etc. input datasets are still handled via streams in the same way, just with datamode == 'GEFS'. Sunset gfs_hafs datamode no longer used.
Specific notes
Contributors other than yourself, if any:
CDEPS Issues Fixed (include github issue #): #64
Are there dependencies on other component PRs (if so list):
Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb
Any User Interface Changes (namelist or namelist defaults changes): Remove gfs and cfsr datm datamodes. Use gefs instead
Testing performed (e.g. aux_cdeps, CESM prealpha, etc): UFS regression test suite
Hashes used for testing: See ufs-community/ufs-weather-model#2389