Update CDEPS#50
Merged
Merged
Conversation
…drof, dwav (ESCOMP#180) * add skip_restart functionality to all components that can use it
* initialize logunit * cleanup stream logunit initialization * remove unused variable logunit
Co-authored-by: Mariana Vertenstein <mvertens@ucar.edu> Co-authored-by: Adrianna Foster <adrifost@ucar.edu>
correct mismatch of leap year ### Description of changes Handle a number of special cases in matching inputdata dates to model dates. These cases are: - Model is no_leap, data is Gregorian and leapyear date 2/29 is encountered in data - skip date - Model is Gregorian, data is no_leap and leapyear date 2/29 is encountered in model - repeat 2/28 data - Model is Gregorian, data is gregorian but leapyears do not align. - if in model leap year repeat data from 2/28 - if in data leap year skip date 2/29 ### Specific notes Contributors other than yourself, if any: @mvertens CDEPS Issues Fixed (include github issue #): ESCOMP#190 Are there dependencies on other component PRs (if so list): ESCOMP/CESM_share#35 Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb Any User Interface Changes (namelist or namelist defaults changes): Testing performed (e.g. aux_cdeps, CESM prealpha, etc): Neon spinup of over 100 years Hashes used for testing: sM ./ccs_config modified sandbox, ccs_config_cesm0.0.44 (branch main) --> ccs_config_cesm0.0.38 ./cime clean sandbox, on cime6.0.45 s ./components/cdeps clean sandbox, 0f3f707 (branch leap_year_corrections) --> cdeps0.12.63 ./components/cdeps/fox clean sandbox, on 4.1.2.1 ./components/cdeps/share/genf90 clean sandbox, on genf90_200608 ./components/cism clean sandbox, on cismwrap_2_1_95 ./components/cism/source_cism clean sandbox, on cism_main_2.01.011 M ./components/cmeps modified sandbox, on cmeps0.13.71 ./components/cpl7 clean sandbox, on cpl7.0.14 ./components/mizuRoute clean sandbox, on 34723c2e4df7caa16812770f8d53ebc83fa22360 ./components/mosart clean sandbox, on mosart1_0_45 ./components/rtm clean sandbox, on rtm1_0_78 e-o ./doc/doc-builder -, not checked out --> v1.0.8 ./libraries/mct clean sandbox, on MCT_2.11.0 ./libraries/parallelio clean sandbox, on pio2_5_7 s ./share clean sandbox, bfa2b5d0a9de06153f2ac94a95818568a1f5cf11 (branch shr_cal_leapyear) --> share1.0.12 ./src/fates clean sandbox, on sci.1.58.1_api.24.1.0
…of sync with data
handle edge case model no_leap, data gregorian
16 tasks
|
@uturuncoglu Have you run cdeps tests in UFS? Do you plan to submit a related PR to ufs-weather-model? Thanks! |
Collaborator
Author
|
@binli2337 I run most of them and they were working but if you want I could run again. I indicated this PR in the top level UFS one. Actually, this updated does not include anything about the land model but I require some fixed in the CDEPS side to make datm+lnd configuration happy. |
|
@uturuncoglu This PR will be merged once UFS PR #1443 is approved. Thanks. |
binli2337
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This updates the NOAA-EMC for from authoritative repository which includes some fixed for GNU compiler that is required datm+lnd configurations.