handle edge case model no_leap, data gregorian

[jedwards4b]

Description of changes

Handles an edge case of model in no_leap and data Gregorian. This case was handled prior to #191 which
messed it up.

Specific notes

Contributors other than yourself, if any:

CDEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs (if so list):

Are changes expected to change answers (bfb, different to roundoff, more substantial):

Any User Interface Changes (namelist or namelist defaults changes):

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):

Hashes used for testing:

[wwieder]

Thanks for looking into this, @jedwards4b. Can we use this hash for testing 50439d3?

I also didn't really understand your comment about RUN_STARTDATE. This shouldn't be modified for LAJA?
Instead, do we need to change ./xmlchange DATM_YR_ALIGN=2018,DATM_YR_END=2021,DATM_YR_START=2018 so just full years are used (e.g. 2019-2021)?

[jedwards4b]

Only full years are used in any case. I don't think you need to modify anything. Yes, please test with that hash and
let me know if you find any further issues.

[billsacks]

@jedwards4b Thank you for all of your work on this tricky problem.

[wwieder]

This case isn't running for some reason. I'm not really sure what to try next?

[wwieder]

This seems to have broken the cases that were previously running
e.g. /glade/scratch/wwieder/run_NEON_v2/tools/site_and_regional/ABBY.ad or */BART.ad

[jedwards4b]

@wwieder I think that this is ready for you to try again now.

[wwieder]

Hi Jim, this seems to be working fro the sites where we have a full 4 years of input data, but not the 'edge cases' where there are only 3 complete years of input data (e.g. LAJA & GUAN with input data 2019-2021, or MOAB that I only want to spin up using 2018-2020). In all cases input data are GREGORIAN and model calendar is running NO_LEAP.

[wwieder]

For reference, I'm creating these cases as follows:

./run_neon.py --neon-sites LAJA --neon-version v2 --run-type ad --base-case ABBY/ --overwrite --start-date 2019-01-01

from the following directory:
/glade/scratch/wwieder/run_NEON_v2/tools/site_and_regional

[jedwards4b]

So sorry. Looking into it now.

[jedwards4b]

I think I have a fix now, running several cases > 100 years to be sure. In the MOAB case I am getting
a different error: (shr_strdata_readstrm) reading file ub: /glade/work/jedwards/sandboxes/ctsm/tools/site_and_regional/MOAB.ad/run/inputdata/atm/cdeps/v2/MOAB/MOAB_atm_2021-02.nc 865
ERROR: _Fillvalue found in stream input variable: PRECTmms

Which is why I guess you only wanted to cycle to 2020 - is there a run_neon option for that?