Skip to content

Update subroutine "shr_stream_init_from_esmfconfig" to process multiple input data files#28

Merged
binli2337 merged 297 commits into
NOAA-EMC:emc/developfrom
binli2337:feature/data_files
May 13, 2021
Merged

Update subroutine "shr_stream_init_from_esmfconfig" to process multiple input data files#28
binli2337 merged 297 commits into
NOAA-EMC:emc/developfrom
binli2337:feature/data_files

Conversation

@binli2337
Copy link
Copy Markdown

Description of changes

Update subroutine "shr_stream_init_from_esmfconfig" to process multiple input data files

Specific notes

CDEPS Issues Fixed: #27

Testing performed:

  • machines and compilers: Hera/Intel

jedwards4b and others added 25 commits April 30, 2021 15:20
…t to DATM_YR_ variables instead of hardcoded values
### Description of changes
Changeing the github action to do annotated tags

### Specific notes

All changes in github actions, testing done on merge.
### Description of changes
Add back stream files for docn_mode=='som_aquap'  PR NOAA-EMC#71 broke several compsets.  

### Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs
 - [ ] CIME (list)
 - [ ] CMEPS (list) 

Are changes expected to change answers?
 - [X] bit for bit
 - [ ] different at roundoff level
 - [ ] more substantial 

Any User Interface Changes (namelist or namelist defaults changes)?
 - [ ] Yes
 - [X] No

Testing performed:
- [X] (required) aux_cdeps
   - machines and compilers: cheyenne, intel 
   - details (e.g. failed tests): ALL pass also tested with PR#73 merged.
   
- [ ] (optional) CESM prealpha test
   - machines and compilers
   - details (e.g. failed tests):

Hashes used for testing:
- [X] CIME
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: master
  - hash: 296aeaf4a
- [X] CMEPS
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: master 
  - hash:c0c2001
- [ ] CESM
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: 
  - hash:
Set the default DATM_YR_* variables for 1PT streams to 2018 to 2019. For the NEON streams use the $DATM_YR_* settings rather than hardcoded values. This allows the case settings of the DATM_YR_* variables change the datm.streams.xml file.

### Description of changes

### Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #): 
  Fixes ESCOMP#78

Are there dependencies on other component PRs: Yes CTSM
 ESCOMP/CTSM#1278

Are changes expected to change answers? No
 - [x] bit for bit

Any User Interface Changes (namelist or namelist defaults changes)? No
 - [x ] No

Testing performed: 
  Ran SMS_D_Vnuopc.CLM_USRDAT.I1PtClm51Bgc.cheyenne_intel.clm-NEON_NIWO
  which worked and PASSes.

Hashes used for testing:
- [ ] CIME.   cime5.6.43
- [ ] CMEPS v0.10.0
 - [ ] CTSM: ctsm5.1.dev036-31-geb5f2e309 (NEON-compset PR ESCOMP/CTSM#1278)
feat(CFSR and GEFS): 
### Description of changes

This PR includes the following updates:
1. Add Fortran module for CFSR data source.
2. Add Fortran module for GEFS data source.
3. Add a new subroutine shr_stream_init_from_esmfconfig to dshr_stream_mod.F90 to get data stream parameters from ESMF configuration files.

### Specific notes
The CFSR and GEFS input forcing files and mesh files are located in the baseline directories of the regression tests. For example, the files are located at /work/noaa/nems/emc.nemspara/RT/NEMSfv3gfs/input-data-20210428/DATM_CDEPS on Orion.

The scripts used to create the mesh files will be added to the following location:
https://github.com/NOAA-EMC/DATM-MOM6-CICE5/tree/develop/utilities.

Contributors other than yourself, if any: Jun.Wang@noaa.gov

CMEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs
 - [ ] CIME (list)
 - [ ] CMEPS (list) 

Are changes expected to change answers?
 - [ ] bit for bit
 - [ ] different at roundoff level
 - [ ] more substantial 

Any User Interface Changes (namelist or namelist defaults changes)?
 - [ ] Yes
 - [ ] No

Testing performed:
- [ ] (required) aux_cdeps
   - machines and compilers:
   - details (e.g. failed tests):
- [ ] (optional) CESM prealpha test
   - machines and compilers
   - details (e.g. failed tests):

Hashes used for testing:
- [ ] CIME
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: nuopc_dev
  - hash:
- [ ] CMEPS
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: nuopc_dev
  - hash:
- [ ] CESM
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: nuopc_dev
  - hash:
chore(actions): change tag prefix to cdeps, bump major
…it rather than extend, as atm forcing shouldn't use a constant value either before or after the data series
…ain if outside the data range for transient cases, remove the extend settings for 1PT tower sites as this shouldn't be done for sub-daily data
### Description of changes

Add in ability to handle 1PT forcing streams for a generic CLM_USRDAT site. This was in MCT, but left off of the NUOPC implementation. NEON sites were added, but not the generic case.

Also change some of the settings of extend from 1PT streams to cycle. And for 1PT cases and NLDAS2 forcing use limit in place of cycle, so you'll see if you are out of the data range.

### Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

  Fixes ESCOMP#86

Are there dependencies on other component PRs
 - [ x] CIME cime5.8.47 #3954

Are changes expected to change answers?
 - [ x] bit for bit


Any User Interface Changes (namelist or namelist defaults changes)?
 - [ ] Yes
 - [ x] No

Testing performed: Ran following single point tests...

SMS_D_Ld5_Mmpi-serial.1x1_mexicocityMEX.I1PtClm50SpRs.cheyenne_intel.clm-default			
SMS_D_Lm1_Mmpi-serial.CLM_USRDAT.I1PtClm50SpRs.cheyenne_intel.clm-USUMB_mct			
SMS_D_Lm1_Mmpi-serial_Vnuopc.CLM_USRDAT.I1PtClm50SpRs.cheyenne_intel.clm-USUMB_nuopc			
SMS_Lm1_Mmpi-serial.1x1_brazil.IHistClm50BgcQianRs.cheyenne_gnu.clm-output_bgc_highfreq			
SMS_Lm1_Mmpi-serial_Vnuopc.1x1_brazil.IHistClm50BgcQianRs.cheyenne_gnu.clm-output_bgc_highfreq

Hashes used for testing:
- [ ] CIME
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - tag: cime5.8.47
- [ ] CMEPS
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - tag: v0.10.0
- [ ] CTSM
  - repository to check out: https://github.com/jedwards4b/CTSM.git
  - branch: neon_compsets
  - describe: ctsm5.1.dev038-37-g8a65d2f19
  - This will be ctsm5.1.dev039
@binli2337 binli2337 merged commit 57bfa1b into NOAA-EMC:emc/develop May 13, 2021
@binli2337 binli2337 deleted the feature/data_files branch June 4, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update subroutine "shr_stream_init_from_esmfconfig" to process multiple data stream files

7 participants