Skip to content

Set default years for 1PT to 2018 to 2019, and use DATM_YR variables for NEON#81

Merged
jedwards4b merged 3 commits into
ESCOMP:masterfrom
ekluzek:fix_neon_years
May 3, 2021
Merged

Set default years for 1PT to 2018 to 2019, and use DATM_YR variables for NEON#81
jedwards4b merged 3 commits into
ESCOMP:masterfrom
ekluzek:fix_neon_years

Conversation

@ekluzek
Copy link
Copy Markdown
Collaborator

@ekluzek ekluzek commented May 1, 2021

Set the default DATM_YR_* variables for 1PT streams to 2018 to 2019. For the NEON streams use the $DATM_YR_* settings rather than hardcoded values. This allows the case settings of the DATM_YR_* variables change the datm.streams.xml file.

Description of changes

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):
Fixes #78

Are there dependencies on other component PRs: Yes CTSM
ESCOMP/CTSM#1278

Are changes expected to change answers? No

  • bit for bit

Any User Interface Changes (namelist or namelist defaults changes)? No

  • [x ] No

Testing performed:
Ran SMS_D_Vnuopc.CLM_USRDAT.I1PtClm51Bgc.cheyenne_intel.clm-NEON_NIWO
which worked and PASSes.

Hashes used for testing:

…t to DATM_YR_ variables instead of hardcoded values
@jedwards4b jedwards4b merged commit 726f4ab into ESCOMP:master May 3, 2021
@jedwards4b
Copy link
Copy Markdown
Contributor

@ekluzek This commit broke the test SMS_Vnuopc_Ld5_P1.1x1_mexicocityMEX.2000_DATM%1PT_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP.cheyenne_intel
which leads me to ask - why was the cdeps testlist not conducted for this PR?

@ekluzek
Copy link
Copy Markdown
Collaborator Author

ekluzek commented May 12, 2021

Ok, obviously now I should have. I haven't run the cdeps test list before, but I can. I thought my changes were sufficiently confined that only the NEON test was needed. But, I suppose this is an example of why we have test lists, because sometimes unexpected things happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NEON data is hardcoded to use 2018-2019 it should use $DATM_YR_START and $DATM_YR_END

2 participants