Set default years for 1PT to 2018 to 2019, and use DATM_YR variables for NEON#81
Merged
Merged
Conversation
…t to DATM_YR_ variables instead of hardcoded values
jedwards4b
approved these changes
May 1, 2021
jedwards4b
approved these changes
May 3, 2021
Contributor
|
@ekluzek This commit broke the test SMS_Vnuopc_Ld5_P1.1x1_mexicocityMEX.2000_DATM%1PT_SLND_SICE_SOCN_SROF_SGLC_SWAV_SESP.cheyenne_intel |
Collaborator
Author
|
Ok, obviously now I should have. I haven't run the cdeps test list before, but I can. I thought my changes were sufficiently confined that only the NEON test was needed. But, I suppose this is an example of why we have test lists, because sometimes unexpected things happen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the default DATM_YR_* variables for 1PT streams to 2018 to 2019. For the NEON streams use the $DATM_YR_* settings rather than hardcoded values. This allows the case settings of the DATM_YR_* variables change the datm.streams.xml file.
Description of changes
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Fixes #78
Are there dependencies on other component PRs: Yes CTSM
ESCOMP/CTSM#1278
Are changes expected to change answers? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed:
Ran SMS_D_Vnuopc.CLM_USRDAT.I1PtClm51Bgc.cheyenne_intel.clm-NEON_NIWO
which worked and PASSes.
Hashes used for testing: