Feature/pt source#18
Conversation
|
@ytangnoaa Could you please bring this up-to-date with NOAA-EMC/develop branch? |
Update CMake build system (#15)
|
Brian
It was updated. See noaa-oar-arl#10
Thanks
Youhua
…On Mon, Oct 17, 2022 at 8:58 AM Brian Curtis ***@***.***> wrote:
@ytangnoaa <https://github.com/ytangnoaa> Could you please bring this
up-to-date with NOAA-EMC/develop branch?
—
Reply to this email directly, view it on GitHub
<#18 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFULDHUFWGJTGPUK6TNB5LDWDVENVANCNFSM6AAAAAAQ64UIRQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi Brain and Chan-Hoo, Is this PR ready to test? |
|
Hi Youhua, It failed with following error message when I tested point-source code. 20221030 153123.833 ERROR PET0000 aqmio.F90:1238 - Field CO not defined in NetCDF data set (strerr=NetCDF: Variable not found, ncerrToCheck=-49) Please see PET0000.ESMF_LogFile at /lfs/h2/emc/ptmp/jianping.huang/emc.para/tmp/run_fcst.17178779.cbqs01 Jianping |
|
@ytangnoaa @bbakernoaa @JianpingHuang-NOAA How is the progress for this? Are the issues with this codebase going to be fixed and available for a PR by the end of next week 11/19? Or should this be skipped for operational implementation? |
Brian, Jianping tested this PR, and it worked as expected. However, it yielded higher surface PM2.5, and we might need longer time evaluation. |
… into feature/pt-source
pull from EMC
|
@bbakernoaa @ytangnoaa is this ready for merge and testing with UFSWM ? Deadline is Wed. |
Brian, thank you for asking. After the bug fixing, the PM2.5 overprediction issue should be resolved. This C18 testing run included this PR. If there is no further comment, you may go ahead to merge it. |
|
@BrianCurtis-NOAA @ytangnoaa Could you please add reviewers for this PR? Does this PR require reviewers' approval before merging? |
I can not add reviewers to this PR. Could Brian help it? Thanks |
BrianCurtis-NOAA
requested review from
JianpingHuang-NOAA,
bbakernoaa and
rmontuoro
|
I've added reviewers. I'd prefer at least 2 reviews before we go to UFSWM with a PR. |
|
@bbakernoaa Hi Barry, can you help us to check whether the point-source emissions have been removed from the NEXUS calculation since I can not find them in my C15 and C19 NRT runs? Please check the NEXUS config file at /lfs/h2/emc/physics/noscrub/jianping.huang/nwdev/packages/aqm.v7.0.15/sorc/arl_nexus/config/cmaq |
|
@JianpingHuang-NOAA Is C15 and C19 without point sources in plume rise? I can't keep track of these |
|
@bbakernoaa I thought C15 and C19 put all the point-source emissions at Level 1. However, I did not see the PT emissions in the NEUS config file. I want to know whether the point source emissions have been removed from the NEXUS calculation by default settings. |
|
To answer that question yes the point sources were removed from the nexus_config file to support the other point source method and to ensure not double counting |
|
Ok, thanks for the confirmation. This means that point-source emissions
were not included in our simulations for C15 and C19. This helps us better
understand the difference of predicted O3 and PM2.5 among C15, C18, and C19
that I presented on 11/29/2022 (here
<https://docs.google.com/presentation/d/1E4o2wKgc2MY6I5TPWKQghU0oVBR2904o/edit#slide=id.g19cf18cd5b5_0_33>
)
…On Fri, Dec 2, 2022 at 3:52 PM Barry Baker ***@***.***> wrote:
To answer that question yes the point sources were removed from the
nexus_config file to support the other point source method and to ensure
not double counting
—
Reply to this email directly, view it on GitHub
<#18 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANA2PIZJZB42UBGEKJ6SHV3WLJOQ7ANCNFSM6AAAAAAQ64UIRQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
… into feature/pt-source
|
With Raffaele's point source code in the repo, I will close this PR. Please let me know if this is in error. |
…flags used in AQMv7 (NOAA-EMC#18) * get -ftrapuv and -check all into DEBUG builds using CMAKE_BUILD_TYPE * Make sure CMAKE_BUILD_TYPE is defined before using string(TOUPPER.) * UPPER_CMAKE_BUILD_TYPE not the correct method here
6 participants
This is the AQM code change part of point-source emissions
For detail, please see
#13