Drop zero coefficients functions #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganize coefficient functions and ESF calculation * tag 'v0.5.0': Bump version
* develop: Bump version Improve bench cov doc
* feature/bench_runners: Fix unit tests related to ProjectileDIS Change name to projectile option in observables Fix observables database layout Minor fix QCDNUM runner Xspace runner Adding xspace runner Fix QCDNUM bindings Update runneres and utils
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
- Coverage 71.34% 71.31% -0.03%
==========================================
Files 48 48
Lines 1888 1900 +12
==========================================
+ Hits 1347 1355 +8
- Misses 541 545 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation it's rather minimal, but it is either working or doing nothing, tested against:
I would like to have a test case in which it is actually dropping something, maybe I completely confused the goal...