UFS-dev PR#42#89
Merged
Merged
Conversation
* add IFI to post * pass w to model & fixes to ccpp/physics changes * send lightning threat indexes to post * upp: remove 444 ltng and add 704 * ccpp/physics: fill ltg*_max with 0 when model is hydrostatic * atmos_cubed_sphere: only send w to model in non-hydrostatic mode, and only if model wants it * disable lightning_threat when hydrostatic, and initialize wgrs * turn off lightning_threat by default since it allocates wgrs and passes w * missing `active = (lightning_threat_indices_enabled)` for wgrd * UPP submodule: correct ifi load on acorn * remove unneeded initialization of ltg*_max in post_fv3 * remove unneeded hydrostatic check from maximum_hourly_diagnostics * fix out-of-bounds access in upp calslr_roebbr * fix another out-of-bounds access and move a message to stdout
dustinswales
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identical to NOAA-EMC#628
Contains changes from #88 until it is merged and this branch is updated.