dtc/hwrf-physics: merge HWRF saSAS with GFS version, update to a more recent version of fv3atm from EMC develop#41
Merged
climbfuji merged 2 commits intoApr 13, 2020
Conversation
369029e to
817fe36
Compare
grantfirl
approved these changes
Apr 13, 2020
Collaborator
grantfirl
left a comment
There was a problem hiding this comment.
Looks OK. A little bit difficult to review with combined changes, but not a big deal.
mzhangw
approved these changes
Apr 13, 2020
| branch = dtc/hwrf-physics | ||
| #url = https://github.com/NCAR/ccpp-physics | ||
| #branch = dtc/hwrf-physics | ||
| url = https://github.com/climbfuji/ccpp-physics |
There was a problem hiding this comment.
I think that we will still use dtc/hwrf-physics for ccpp-physics,
Author
There was a problem hiding this comment.
Tiny glitch, sorry. This change will be reverted anyway once ccpp-physics is merged. Thanks!
dustinswales
pushed a commit
to dustinswales/fv3atm
that referenced
this pull request
Apr 30, 2020
* netcdf parallel writing and lon/lat in netcdf file * some changes to get it to (almost) run on hera * lat should be in degrees - remove conversion to radians. * import updates from jswhit/fv3atm * more bug fixes - now works on hera * specify collective access if compression turned on. * use classic model * bug fixes for parallel IO with compression * fix calculation of max compression error * turn off shuffle filter * code simplification * remove debug print * don't use parallel IO for 2d file (since it seems to increase run time) * allow multiple values of output_file, as long as they all start with 'netcdf' * use default chunksize for 2d vars * delete commented out macro ESMF_ERR_ABORT * delete rad2dg * add module_write_netcdf_parallel.F90 * add option to build without parallel netcdf (-DNO_PARALLEL_NETCDF) * fix typo * stub file for building without parallel netcdf lib * allow chunksizes for 2d arrays to be set in model_configure (ichunk2d,jchunk2d) Default is size of array on each write task. * add ichunk3d,jchunk3d,kchunk3d to specify 3d chunksizes. Default is now ichunk3d,jchunk3d same as array size on each PE, kchunk3d=nlevs This results in the fastest writes on hera. * fix typo * put ifdefs in module_write_netcdf_parallel.F90 so no stub file needed * don't need this file anymore * remove module_write_netcdf_parallel_stub.o target * use specified chunksizes for serial IO. If chunksize parameter negative, let netcdf library choose defaults. * update comments * get output_file without esmf call error * syntax fix * fix stub interface in module_write_netcdf_parallel.F90 for cmake build Co-authored-by: junwang-noaa <37633869+junwang-noaa@users.noreply.github.com>
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/fv3atm
that referenced
this pull request
Mar 16, 2023
…le pointer update for NOAA-EMC#462 (NOAA-EMC#634) * add nssl_alphar, nssl_ehw0_in, nssl_ehlw0_in to namelist entries for ensemble perturbationsons * update the standard name for hail/graupel collection efficiency * update the long names for parameters related to NSSL microphysics * update ccpp/physics and ccpp/framework submodule pointers --------- Co-authored-by: Jili Dong <Jili.Dong@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains
Associated PRs:
NCAR/ccpp-physics#433
#41
NCAR/ufs-weather-model#39
For regression testing information, see NCAR/ufs-weather-model#39.