RRTMG lw/sw radiation updates from NEMSfv3gfs#50
Merged
grantfirl merged 1 commit intoJun 27, 2018
Conversation
…adiation updates etc
This was referenced Jun 26, 2018
Collaborator
Author
|
@grantfirl I think it would make sense for you to take a close look, because I haven't done any testing of other cases than twpice (in particular, I have not updated any files that relate to prescribed surface fluxes). Note that this PR can go in later than all the others, the functionality of NEMSfv3gfs doesn't depend on it. |
grantfirl
approved these changes
Jun 27, 2018
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
The changes look fine to me, although I did not test. I'll approve these so that we can merge this update in and I'll do some testing/troubleshooting after the fact.
dustinswales
pushed a commit
to dustinswales/ccpp-scm
that referenced
this pull request
May 16, 2022
…from-nemsfv3gfs RRTMG lw/sw radiation updates from NEMSfv3gfs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the metadata tables in src/gmtb_scm_type_defs.f90 to run the updated RRTMG lw/sw schemes from NEMSfv3gfs current trunk. This PR requires several PRs listed below to be merged at the same time.
SCM was tested on MacOSX/GNU for the twpice testcase only.