ccpp-framework RRTMG lw/sw radiation CCPP-compliant#85
Merged
Conversation
…ds) for RRTMG lw/sw schemes, change name of schemefile GFS_suite_interstitial.ccpp.F90 to GFS_suite_interstitial.F90
…nterstitials and their dependencies; add new optional arguments (clouds) for RRTMG lw/sw schemes, change name of schemefile GFS_suite_interstitial.ccpp.F90 to GFS_suite_interstitial.F90
… add new group 'time_vary' that currently contains only the GFS_rrtmg_setup scheme and new group 'radiation' that contains all schemes required in this group
…ccpp-framework-radiation-ccpp
… add missing entries for hedmf and samfdeepcnv schemes to SDF group physics in order as they appear in the physics driver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the previously introduced HRRR Thompson MP from the default SDF and provides a separate SDF for testing this scheme.
It also introduces the "time_vary" and "radiation" groups required to run the CCPP-compliant radiation in NEMSfv3gfs.
This PR requires several other PRs listed below to go in at the same time.
Update: The results are bit for bit identical on MacOSX/GNU and Theia/Intel both with and without threading.