address gfortran compilation warning for ugwp_driver_v0.F#354
Merged
climbfuji merged 2 commits intoNov 25, 2019
Merged
Conversation
grantfirl
requested review from
JulieSchramm,
climbfuji and
llpcarson
as code owners
Collaborator
|
@grantfirl has Valery seen and approved your changes? I am trying to compile SCM with Intel in debug mode (without this fix), and I am getting compilation errors: |
Collaborator
|
@junwang-noaa @DusanJovic-NOAA you may want to know about this |
Collaborator
Author
No, Valery isn't aware of this, AFAIK. I can't find his GitHub username. I'll just email him and send him a link to this PR. |
Collaborator
Author
|
Associated PR: NCAR/fv3atm#4 Note that Valery has approved this fix. |
Collaborator
Author
|
@climbfuji Since this only affects non-active code, I don't see a point in running RTs, do you? If no RTs needed, this is ready to merge. |
climbfuji
approved these changes
Nov 25, 2019
This was referenced Nov 25, 2019
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
…N options on (NCAR#354) Add a WAM regression test with the MULTI_GASES and MOLECULAR_DIFFUSION options on Co-authored-by: Sajal.Kar <Sajal.Kar@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gfortran compiler complains that the arguments supplied to the calls to two subroutines in ugwp_driver_v0.F are mismatched. I think that this fixes the issue, but Valery Yudin should confirm.
Note that this code is not currently being executed. These calls occur in edmix_ugwp_v0 subroutine, whose one call is bypassed via a return statement before its execution in cires_ugwp_driver_v0 in IPD physics and cires_ugwp_run in CCPP physics. Since these changes are not actually executed, I don't necessarily see a point in running RTs.
The same issue exists in the IPD version of the physics in the fv3atm repo.