Bugfix for MG array allocation PR #291#293
Merged
climbfuji merged 10 commits intoAug 17, 2019
Merged
Conversation
… (since memory is conditionally allocated)
…osition for fixed format file
Bugfix for SCM only
…_array_allocation_bugfix
grantfirl
reviewed
Aug 16, 2019
grantfirl
approved these changes
Aug 16, 2019
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Approved, but I was involved with this so @llpcarson might want to review too.
llpcarson
approved these changes
Aug 16, 2019
Contributor
llpcarson
left a comment
llpcarson
left a comment
There was a problem hiding this comment.
Approved, pending regression test completion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated PRs:
https://github.com/NCAR/NEMSfv3gfs/pull/212
#293
https://github.com/NCAR/FV3/pull/184
NCAR/ccpp-framework#208
NCAR/NEMS#1
For regression testing, see https://github.com/NCAR/NEMSfv3gfs/pull/212.
Changes for ccpp-physics:
physics/samfdeepcnv.fback to column 73 as required by the Fortran fixed file format.physics/docs/ccpplatex_doxto work with the automatically generated html metadata tables and to readmachine.meta(to document the kind definitions in the future)