Skip to content

Bugfix for SCM only#295

Merged
grantfirl merged 1 commit into
NCAR:masterfrom
grantfirl:fix_master_19_8_13
Aug 14, 2019
Merged

Bugfix for SCM only#295
grantfirl merged 1 commit into
NCAR:masterfrom
grantfirl:fix_master_19_8_13

Conversation

@grantfirl
Copy link
Copy Markdown
Collaborator

remove loops over nblks in SCM version of GFS_phys_time_vary; no effect on FV3

Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has been tested in gmtb/develop for SCM and is required to fix the gmtb-scm master branch. It does not affect NEMSfv3gfs at all, because the file that is changed (GFS_phys_time_vary.scm.F90) is not used by CCPP in NEMSfv3gfs at all. The proposed changes were communicated to EMC and we received the go-ahead.

@grantfirl
Copy link
Copy Markdown
Collaborator Author

@climbfuji Thanks for communicating with Jun and Dusan at EMC regarding this change.

@grantfirl grantfirl merged commit 2934966 into NCAR:master Aug 14, 2019
grantfirl pushed a commit to dustinswales/ccpp-physics that referenced this pull request Jul 11, 2025
Combo PR (merge from NCAR/main, ECMWF GWD, maxmf bugfix, NEPTUNE reproducibility, mersenne bugfix)
@dustinswales dustinswales mentioned this pull request Jul 14, 2025
grantfirl added a commit that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants