Conditionally allocate Morrison-Gettelman arrays#291
Merged
Conversation
… (since memory is conditionally allocated)
Collaborator
Author
|
Associated PRs: |
grantfirl
commented
Jul 31, 2019
| @@ -297,10 +297,16 @@ subroutine m_micro_run( im, ix, lm, flipv, dt_i & | |||
| & lwheat_i,swheat_i | |||
Collaborator
Author
There was a problem hiding this comment.
It may not be necessary to use assumed-shape arrays in the MG scheme itself since it presumably won't be called unless imp_physics == imp_physics_mg, but I did this to be consistent across all schemes.
Collaborator
Author
|
Note: MG arrays are also used in m_micro_interstitial.F90, but the arrays inside this scheme were already assumed-shape. |
climbfuji
added a commit
that referenced
this pull request
Aug 17, 2019
Bugfix for MG array allocation PR #291
hannahcbarnes
pushed a commit
to hannahcbarnes/ccpp-physics
that referenced
this pull request
Aug 3, 2022
… UGWP bugfixes, LTP bugfixes, sfcsub update, framework update (NCAR#291) * ugwpv1_gsldrag bug fixes, and GFS_typdefs updates associated with diag flags for ugwpv1_gsldrag and GFS_DCNV_generic.F90 * Change vertical dimension of arrays atmosphere_heat_diffusivity (aka dkt) and atmosphere_momentum_diffusivity (aka dku), update long names * Updaate .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for code review and testing * Update descriptions of dku and dkt in ccpp/driver/GFS_diagnostics.F90 to match what is in the CCPP metadata * Revert .gitmodules and update submodule pointers for ccpp-framework and ccpp-physics Co-authored-by: Michael Toy <michael.toy@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deep convection schemes use the Morrison-Gettelman arrays. Since they are conditionally allocated, make sure that the schemes that use them have assumed-shape dummy arguments.