ufs-community ccpp-physics PR#316#1165
Merged
Merged
Conversation
…2atm Replace icplocn2atm (integer) with use_oceanuv (logical)
scrasmussen
requested review from
cenlinhe,
dustinswales,
grantfirl and
rhaesung
as code owners
hertneky
reviewed
Oct 2, 2025
Collaborator
hertneky
left a comment
hertneky
left a comment
There was a problem hiding this comment.
The changes look good for PR316.
But please change the title and links in the PR description to point to 316 and not 307 to avoid confusion. Thanks!
climbfuji
approved these changes
Oct 2, 2025
scrasmussen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
Bringing over changes in ufs-community#316
Dependencies:
Add any links to parent PRs (e.g. SCM and/or UFS PRs) or submodules (e.g. rte-rrtmgp). For example:
Related PRs