gmtb/develop: address issue #301 (fix RUC LSM precip partitioning)#307
Merged
climbfuji merged 1 commit intoAug 27, 2019
Conversation
…hat it is consistent with the code in GFS_MP_generic_post_run
Collaborator
Author
|
@grantfirl I cherry-picked your commit and applied it 1:1 for gmtb/develop |
Collaborator
Author
|
Regression testing on theia/intel: rt_ccpp_gsd.conf in create and verify mode, all tests pass |
grantfirl
approved these changes
Aug 27, 2019
Collaborator
grantfirl
left a comment
grantfirl
left a comment
There was a problem hiding this comment.
Approved. Did you look to see if this had much of an impact in the results when using RUC LSM? I'm not sure what to expect there.
Collaborator
Author
No, but given that this is an obvious mistake and that @tanyasmirnova wants to see this fixed I assume we can go ahead. There will be more changes to the answers when #300 is merged. |
dustinswales
pushed a commit
to dustinswales/ccpp-physics
that referenced
this pull request
Sep 18, 2025
…2atm Replace icplocn2atm (integer) with use_oceanuv (logical)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same change as #303, but for gmtb/develop instead of gsd/develop.
The changes here and in the associated PR for FV3 (https://github.com/NCAR/FV3/pull/194) only affect RUC LSM, hence it is sufficient to run the GSD regression test suite on theia to make sure the code compiles and the GSD suite runs to completion.