Cleanup GFS_layer and CMakeLists for GMTB-SCM (ccpp-physics)#109
Merged
climbfuji merged 2 commits intoJul 2, 2018
Merged
Conversation
…te_setup_scm.F90 from GFS_layer to physics
…CCPP-SCM (newly defined in SCM's CMakeLists.txt, until now assumed as default = project 'Unknown'), replace explicit list of schemes and caps with auto-generated versions
Collaborator
Author
climbfuji
pushed a commit
to climbfuji/ccpp-physics
that referenced
this pull request
Oct 25, 2021
…in_20211019 Update gsl/develop from main 2021/10/19
dustinswales
pushed a commit
to dustinswales/ccpp-physics
that referenced
this pull request
Oct 18, 2023
passing nc back from microphysics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the GFS_layer directory and places GFS_suite_setup_scm.F90 in physics (GFS_typedefs.F90 is moved to the gmtb-scm repository where it belongs).
The PR also replaces the hardcoded list of schemes and caps for SCM with the auto-generated cmake include files and performs cleanup work in the various CMakeLists.txt files.
This PR goes together with the two PRs listed below.
Changes tested for bit-for-bit reproducibility with SCM and NEMSfv3gfs (although changes do not affect NEMSfv3gfs, but to be on the safe side) on MacOSX/GNU.