UFS-dev PR#118#1040
Merged
Merged
Conversation
passing nc back from microphysics
grantfirl
requested review from
AndersJensen-NOAA,
Qingfu-Liu,
RuiyuSun,
dustinswales and
gthompsnWRF
as code owners
grantfirl
requested review from
mkavulich
and removed request for
AndersJensen-NOAA,
RuiyuSun,
dustinswales and
gthompsnWRF
| enddo | ||
| endif | ||
|
|
||
| if (merra2_aerosol_aware) then |
Collaborator
There was a problem hiding this comment.
I think combining code (like done above) is better here than adding more lines. Would this work?
if (is_aerosol_aware) then
if ( PRESENT (aero_ind_fdb) ) then
if ( .not. aero_ind_fdb) then
nwfa1d(kts) = nwfa1d(kts) + nwfa2d(i,j)*dt
nifa1d(kts) = nifa1d(kts) + nifa2d(i,j)*dt
endif
else
nwfa1d(kts) = nwfa1d(kts) + nwfa2d(i,j)*dt
nifa1d(kts) = nifa1d(kts) + nifa2d(i,j)*dt
end if
endif
if (is_aerosol_aware .or. merra2_aerosol_aware) then
do k = kts, kte
nc(i,k,j) = nc1d(k)
nwfa(i,k,j) = nwfa1d(k)
nifa(i,k,j) = nifa1d(k)
enddo
endif
Collaborator
Author
There was a problem hiding this comment.
@AndersJensen-NOAA Yes, I agree with you. I think it would be best to do this simplification in ufs-community#147. When we bring UFS PRs into the NCAR (root) repo, we're not wanting to introduce new changes that represent "deltas" with the UFS repo.
AndersJensen-NOAA
previously requested changes
Jan 31, 2024
Collaborator
AndersJensen-NOAA
left a comment
AndersJensen-NOAA
left a comment
There was a problem hiding this comment.
See comment on combining with aerosol aware code already in place.
Qingfu-Liu
approved these changes
Feb 1, 2024
grantfirl
dismissed
AndersJensen-NOAA’s stale review
Requested changes should go elsewhere to avoid deltas between main and ufs/dev branches.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines ufs-community#118 and ufs-community#109