ccpp_prebuild: Update CCPP metadata for error flag variable and constant one#428
Merged
Merged
Conversation
…pgen_20211105 Merge main into feature capgen 2021/11/05
…ntains Do not require label on end subroutine statement
…ines_contains Fix capgen Fortran parser to recognize nested subroutines/functions
…_main_20220109 Update feature/capgen from main 2022/01/09
…pts/suite_objects.py
…_update feature/capgen: ccpp_error_message unit update
…build scripts, correct unit for ccpp_constant_one in ccpp_prebuild scripts
climbfuji
added
the
capgen-unification
This was referenced Jan 16, 2022
climbfuji
requested review from
gold2718,
grantfirl and
mkavulich
as code owners
… hooks and subroutine
gold2718
approved these changes
Jan 17, 2022
Collaborator
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
Looks good including a couple of items that need to be ported back to feature/capgen (I think).
Comment on lines
+52
to
+55
| 'ccpp_error_code' : Var(local_name = 'ierr', | ||
| standard_name = 'ccpp_error_code', | ||
| long_name = 'error code for error handling in CCPP', | ||
| units = '1', |
Collaborator
There was a problem hiding this comment.
This needs to get back to feature/capgen, right?
Collaborator
Author
There was a problem hiding this comment.
Yes, that's right. Next formal update of feature/capgen from main. This is the prebuild side of things, not used by capgen.
Comment on lines
+21
to
+24
| _API_LOGGING = init_log('metadata_parser') | ||
| _DUMMY_RUN_ENV = CCPPFrameworkEnv(_API_LOGGING, ndict={'host_files':'', | ||
| 'scheme_files':'', | ||
| 'suites':''}) |
Collaborator
There was a problem hiding this comment.
This can come back to feature/capgen
Collaborator
Author
There was a problem hiding this comment.
Same here, prebuild script. Will come back with the next update of feature/capgen from main.
…ata_and_subroutine Add system test for doxygen comments between metadata hooks and CCPP entry point (subroutine)
… into ccpp_error_code_in_prebuild
grantfirl
approved these changes
Jan 18, 2022
mkavulich
added a commit
to mkavulich/ccpp-doc
that referenced
this pull request
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge feature/capgen into main and correct standard name and unit of CCPP metadata for error flag variable in the prebuild scripts, as well as the unit of
ccpp_constant_onein the prebuild scripts.Merging feature/capgen into main removes a workaround in the capgen metadata parser (parse checker) that was used in main only. Without the workaround, a mismatch of the unit of
ccpp_constant_oneis now an error.Also:
capgen.pyusesccpp_error_codewith unit1instead ofccpp_error_flagwith unitflag. This PR changes theccpp_prebuild.pyside to follow whatcapgenis doing.User interface changes?: No (for the ccpp-framework side), yes for existing schemes in NCAR ccpp-physics main. Need to update standard name and unit of the CCPP error flag variable
Fixes #397.
Testing:
test removed: none
unit/system tests: capgen tests (
tests/run_test.sh) passregression testing: see ufs-community/ufs-weather-model#1013
Associated PRs:
#428
NCAR/ccpp-physics#828
NOAA-EMC/ufsatm#467
ufs-community/ufs-weather-model#1013