Skip to content

feature/capgen: ccpp_error_message unit update#427

Merged
climbfuji merged 2 commits into
NCAR:feature/capgenfrom
climbfuji:feature_capgen_errmsg_unit_update
Jan 13, 2022
Merged

feature/capgen: ccpp_error_message unit update#427
climbfuji merged 2 commits into
NCAR:feature/capgenfrom
climbfuji:feature_capgen_errmsg_unit_update

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Jan 13, 2022

Update unit of ccpp_error_message from 1 to none.

For feature/capgen: Update unit of ccpp_error_message from 1 to none as described in #397. When these changes get merged back to main, the workaround in parse_checkers.py that is only in main, not in feature/capgen, must also be removed.

User interface changes?: No

Fixes : [Github issue #s] And brief description of each issue.

Testing:
test removed: none
unit tests:
I ran the following doctests without failures:

ccpp-framework-errmsg-unit-update-feature-capgen/scripts/parse_tools [gccgfortran-py3-hpc-stack-1.2.1]> python parse_checkers.py
ccpp-framework-errmsg-unit-update-feature-capgen/scripts/parse_tools [gccgfortran-py3-hpc-stack-1.2.1]> python parse_log.py
ccpp-framework-errmsg-unit-update-feature-capgen/scripts/parse_tools [gccgfortran-py3-hpc-stack-1.2.1]> python parse_object.py
ccpp-framework-errmsg-unit-update-feature-capgen/scripts/parse_tools [gccgfortran-py3-hpc-stack-1.2.1]> python parse_source.py
ccpp-framework-errmsg-unit-update-feature-capgen/scripts/parse_tools [gccgfortran-py3-hpc-stack-1.2.1]> python preprocess.py
ccpp-framework-errmsg-unit-update-feature-capgen/scripts/parse_tools [gccgfortran-py3-hpc-stack-1.2.1]> python xml_tools.py
ccpp-framework-errmsg-unit-update-feature-capgen/scripts/parse_tools [gccgfortran-py3-hpc-stack-1.2.1]> cd ..
ccpp-framework-errmsg-unit-update-feature-capgen/scripts [gccgfortran-py3-hpc-stack-1.2.1]> python metadata_table.py
ccpp-framework-errmsg-unit-update-feature-capgen/scripts [gccgfortran-py3-hpc-stack-1.2.1]> python metavar.py
ccpp-framework-errmsg-unit-update-feature-capgen/scripts [gccgfortran-py3-hpc-stack-1.2.1]> python constituents.py

system tests:
I ran run_tests.sh in directory tests, all tests passed.

manual testing:
I tried to test this with the UFS. After removing the workaround in parse_checkers.py, the code generator tripped over the errflg mismatch that I just mentioned in ESCOMP/ESMStandardNames#19. A test with the UFS can only happen after this PR is merged into feature/capgen, and a reverse PR that updates main from feature/capgen and fixes errflg is created.

@climbfuji climbfuji marked this pull request as ready for review January 13, 2022 04:24
@climbfuji climbfuji requested a review from gold2718 as a code owner January 13, 2022 04:24
Copy link
Copy Markdown
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@climbfuji climbfuji merged commit 565ede6 into NCAR:feature/capgen Jan 13, 2022
@climbfuji climbfuji deleted the feature_capgen_errmsg_unit_update branch June 27, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants