feature/capgen: ccpp_error_message unit update#427
Merged
climbfuji merged 2 commits intoJan 13, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update unit of
ccpp_error_messagefrom1tonone.For feature/capgen: Update unit of
ccpp_error_messagefrom1tononeas described in #397. When these changes get merged back to main, the workaround inparse_checkers.pythat is only in main, not in feature/capgen, must also be removed.User interface changes?: No
Fixes : [Github issue #s] And brief description of each issue.
Testing:
test removed: none
unit tests:
I ran the following doctests without failures:
system tests:
I ran
run_tests.shin directorytests, all tests passed.manual testing:
I tried to test this with the UFS. After removing the workaround in
parse_checkers.py, the code generator tripped over theerrflgmismatch that I just mentioned in ESCOMP/ESMStandardNames#19. A test with the UFS can only happen after this PR is merged into feature/capgen, and a reverse PR that updates main from feature/capgen and fixeserrflgis created.