Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Automate prod and test image creation #877

Merged
merged 3 commits into from
Oct 12, 2023
Merged

feat: Automate prod and test image creation #877

merged 3 commits into from
Oct 12, 2023

Conversation

jonandernovella
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #856

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

Images for prod and test should be created in the following scenarios:

  • Merge to develop
  • Merge to main

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@jonandernovella
feat: Automate prod and test image creation
5c39fd9 
In the following scenarios:
- Merge to develop
- Merge to main

Images for prod and test should be created.
@jonandernovella
fix: tag pub depends on image pub
b9ac707
@jonandernovella jonandernovella marked this pull request as ready for review October 12, 2023 07:14
@andkaha
Copy link
Member

andkaha commented Oct 12, 2023 •
edited
Loading

Will this keep the versions of urdr and urdr-web in sync? I can see a 1.2.0 image for urdr, but no image exists for urdr-web with that version.

@jonandernovella
Copy link
Contributor Author

Will this keep the versions of urdr and urdr-web in sync? I can see a 1.2.0 image for urdr, but no image exists for urdr-web with that version.

It should. I deleted the urdr-web images but forgot to delete the urdr ones. Now they should all be gone.

andkaha
andkaha approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@andkaha andkaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and will merge, then we'll see how it works in practice. Good job!

@andkaha andkaha merged commit d9fde6e into develop Oct 12, 2023
@andkaha andkaha deleted the feat/automated-tags branch October 12, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andkaha andkaha andkaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Automate urdr releases
2 participants
@jonandernovella @andkaha