Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for editing absence ranges #652

Merged
merged 5 commits into from
Sep 15, 2022
Merged

Add function for editing absence ranges #652

merged 5 commits into from
Sep 15, 2022

Conversation

jonandernovella
Copy link
Contributor

@jonandernovella jonandernovella commented Sep 14, 2022

Related issue(s) and PR(s)

This PR closes #599

We still need the UI component for specifying the new ranges, which could be another issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • New function which allows updating existing absence ranges
  • Added better error handling

Testing

  • Test creating, editing and removing
  • At the moment, the edit button will update the absence range to be as of the date of the current day

As well as a bit of refactoring for better error handling
@jonandernovella jonandernovella requested a review from a team September 14, 2022 16:31
@KattisLej
Copy link
Contributor

Starting review

Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment- checking so the date is not already reported for
I think the code and implementation looks good.

Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@KattisLej KattisLej merged commit bb55dfa into develop Sep 15, 2022
@KattisLej KattisLej deleted the dev/edit branch September 15, 2022 08:10
@jonandernovella jonandernovella mentioned this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

edit a planned vacation period
2 participants