Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix autocomplete in footer #649

Merged
merged 2 commits into from
Sep 14, 2022
Merged

fix autocomplete in footer #649

merged 2 commits into from
Sep 14, 2022

Conversation

HenrikeW
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #648

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • the height property on the .quick-add class was removed
  • the .footer-container class was modified to prevent the input elements in the footer from moving when the unsaved changes warning is displayed.

Screenshot of the fix

Testing

This bug is about the autocomplete box appearing when you search for an issue as well as the unsaved-changes-warning. Play around with these two in mobile and desktop view and see if everything looks good.
The warning should appear above the save button when you have unsaved changes. The footer should slightly expand for this, but all the elements within the footer should stay in place.
When you start searching with free text in the issue input field, the box with suggestions should appear below, moving the input elements above it higher up.

Further comments

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@HenrikeW HenrikeW requested a review from a team September 13, 2022 12:07
@KattisLej
Copy link
Contributor

Starting review

Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and it looks like a very good solution, well done

@jonandernovella jonandernovella self-requested a review September 13, 2022 16:19
Copy link
Contributor

@jonandernovella jonandernovella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just realised that the text in the add button changed, and the help page has not been updated accordingly.

See here

@HenrikeW
Copy link
Contributor Author

Looks good! I just realised that the text in the add button changed, and the help page has not been updated accordingly.

See here

Oh, good catch! Fixed it now.

@jonandernovella jonandernovella merged commit fc7a906 into develop Sep 14, 2022
@jonandernovella jonandernovella deleted the fix/issue-searchbox branch September 14, 2022 06:54
@jonandernovella jonandernovella mentioned this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dropdown box for issue search not visible on desktop
3 participants