Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar chart fixes and help page #628

Merged
merged 5 commits into from
Sep 6, 2022
Merged

Bar chart fixes and help page #628

merged 5 commits into from
Sep 6, 2022

Conversation

HenrikeW
Copy link
Contributor

@HenrikeW HenrikeW commented Sep 6, 2022

Related issue(s) and PR(s)

This PR closes #612, closes #619 and closes #620.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • the time span for the bar chart was extended to the full current year
  • the heading for the bar chart was changed
  • a section for the bar chart on the help page was added

Screenshot of the fix

Testing

  • Go to the report page and log some time during different times. Only time entries between Jan 1st 2022 and Dec 31st 2022 should be represented in the chart.
  • Read the help page section and check if it's complete, correct and understandable.

Further comments

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@HenrikeW HenrikeW requested a review from a team September 6, 2022 06:36
Copy link
Contributor

@jonandernovella jonandernovella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few suggestions to improve the help page.

@jonandernovella jonandernovella self-requested a review September 6, 2022 07:56
Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jonandernovella jonandernovella merged commit c525f2f into develop Sep 6, 2022
@jonandernovella jonandernovella deleted the dev/barchart-fix branch September 6, 2022 08:05
@jonandernovella jonandernovella mentioned this pull request Sep 6, 2022
@jonandernovella jonandernovella mentioned this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants