Feature/alpine containers #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use images that are based on Alpine 3.16 throughout. * For the Nginx image, there is no `-alpine3.16` image, only a `-alpine` image, so use that one instead.
The Bash shell is not included by default in Alpine-based images.
* Remove the use of the Bash shell, and * Switch to using the `apk` package manager in place of `apt`.
kusalananda
added
security
|
The linters require further changes. I will look at these tonight or during the weekend. |
* Drop explicit `apk` udate and use `apk --no-cache` instead. * Pin package velisons for `apk` (at least major versions). * Use `ash` as the shell in `backend/Dockerfile` to get access to `pipefail` shell option.
Also add `--silent` option to `curl`.
jonandernovella
approved these changes
Sep 5, 2022
|
I'm merging this as @KattisLej also reported successfully using the updated Docker setup. |
Merged
kusalananda
added a commit
that referenced
this pull request
Sep 6, 2022
This was an oversight that should have been part of #625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #624.
Type of change
List of changes made
The choice of Docker containers used by the project was altered. With this PR, we now pick Docker containers based on the Alpine Linux 3.16 release (or just a generic Alpine Linux if the release number can't be chosen). The Alpine Linux distribution appears to be more proactive in patching known vulnerabilities.
In addition to simply changing the Docker image that is used, some files had to be updated to deal with the fact that the Alpine distribution uses
apkas its package manager rather thanapt.Updates, summarised:
backend/Dockerfile:golang:1.17.11-stretch-->golang:1.19-alpine3.16node/Dockerfile:node:18.8.0-slim-->node:18.8.0-alpineproduction/Dockerfile:golang:1.18.5-alpine3.15-->golang:1.19-alpine3.16alpine:3.16.2-->alpine:3.16(to ensure everything is using the same release of Alpine)production/Dockerfile.nginx:node:18.8.0-slim-->node:18.8.0-alpine3.16(x2)nginx:1.23.1-->nginx:1.23.1-alpine(there is no-alpine3.16)Other tweaks to
docker-compose.ymlas well as to bothbackend/Dockerfileandproduction/Dockerfilewere made toWhile here, I have also updated the Go language version used by the Github actions from 1.17 to 1.19.
Testing
Definition of Done checklist