-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizontal bar for time overview #590
Conversation
6890930
to
ca7af4a
Compare
Are the elements of the bar sorted in any particular way? Is it guaranteed always to show the activities in the same order? EDIT: No, it appears to sort the activities in most-recently-used order (or something similar, possibly semi-randomly). EDIT: The colors are assigned left-to-right, not to the specific activities. Suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
Found a border-test issue. If no time has been reported, the bar is not visible. If time is then added and the user saves the changes, the bar does not appear until the page is reloaded.
Same thing when the bar is visible and time entries are saved, it does not alter until the page is reloaded.
Another issue is that the order of the activities seems to be random. Usage would be easier if they always appear in the same order and with the same color.
EDIT: Sorting makes it a lot better. Agree that colors should be fixed for activities.
Thanks for your feedback! I totally agree that the colors should be fixed for activities but that requires a full list of all possible activities. There might also be requirements on what type of activities should have what type of colors, so I'd like to create a new issue for that and address it in a later PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Sorting and updating after saving changes makes this good enough for now. We can look at deciding color-activity match later on.
Related issue(s) and PR(s)
This PR relates to #580.
Type of change
List of changes made
Screenshot of the fix
Testing
Further comments
Definition of Done checklist