Improve mobile UX when using urdr #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These mostly apply to portrait mode.
With new header class and shorter title
jonandernovella
force-pushed
the
dev/layout-scroll
branch
2 times, most recently
from
27f034c to
edf0090
Compare
HenrikeW
requested changes
Aug 18, 2022
There was a problem hiding this comment.
Much better than before, nice job!
(I couldn't really test it on my phone because I don't manage to get a connection to redmine there and can't see any rows in the spreadsheet). But using dev tools on my computer, it looks nice.
Two small comments in the code, that's it.
HenrikeW
approved these changes
Aug 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Testing