Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use issues.json to get search issue subjects #553

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Use issues.json to get search issue subjects #553

merged 2 commits into from
Aug 8, 2022

Conversation

jonandernovella
Copy link
Contributor

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • Use issues redmine api to get issue subjects, since the search api does not return what we want.
  • Limit suggestions to 5 hits

Testing

  • Usual procedure

@jonandernovella
Clean up issueSearchHandler
5f429c2 
Do not rely on the title returned by search api, but instead use the issues api to get the correct subjects.
@jonandernovella
Limit suggestions to 5 hits
1a100fb 
This will reduce the load on the redmine api since 25 queries is quite a lot...
@jonandernovella jonandernovella requested a review from a team August 8, 2022 08:14
@jonandernovella jonandernovella merged commit dfefb6b into develop Aug 8, 2022
@jonandernovella jonandernovella deleted the dev/search-improvements branch August 8, 2022 08:27
@jonandernovella jonandernovella mentioned this pull request Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonandernovella