remove loading overlay before warning toast appears

[HenrikeW]

Related issue(s) and PR(s)

The toast appearing after a failing time report attempt was covered by the loading overlay.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Other

List of changes made

The loading overlay is switched off before the warning error is caught

Screenshot of the fix

Testing

Test a failed report:

• add an invalid combination of issue and activity:
  • choose "Design" in the activity dropdown
  • type any valid issue number and select the issue
  • add it with the plus button
• add a time entry on the newly added row
• press "Save changes"
• you should see the loading overlay for a short while, then it should disappear and a warning toast should be shown

Test a success report:

• add a time entry to any valid row in your interface
• press "Save changes"
• you should see the same behavior as before: the loading overlay for a short while, then it should disappear and a success toast should be shown

Further comments

Definition of Done checklist

• I have made an effort making the commit history understandable
• I have performed a self-review of my own code and commented any hard-to-understand areas
• Tests and lint/format validations are passing
• My changes generate no new warnings