Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework search suggestions navigation #542

Merged
5 commits merged into from
Aug 4, 2022
Merged

Rework search suggestions navigation #542

5 commits merged into from
Aug 4, 2022

Conversation

jonandernovella
Copy link
Contributor

@jonandernovella jonandernovella commented Aug 3, 2022

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • Added handleAutocompleteNavigation to handle arrow navigation over suggestions
  • Added handleInputToAutocompleteFocus to handle the focus switch from search input to suggestions list

Testing

  • Usual procedure

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@jonandernovella jonandernovella requested a review from a team August 3, 2022 10:51
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Looks reasonable.

@HenrikeW
Copy link
Contributor

HenrikeW commented Aug 3, 2022

starting review

@HenrikeW
Copy link
Contributor

HenrikeW commented Aug 3, 2022

Think this is awesome! Haven't looked at the linter stuff yet though.

@HenrikeW
Copy link
Contributor

HenrikeW commented Aug 3, 2022

Okay, I'd ignore the linter in this case. It makes sense to keep the two functionalities apart.
Seems like you can ignore a code block with

// jscpd:ignore-start

some code 

// jscpd:ignore-end

Haven't tried it because I can't run the linter locally and didn't wanna push.

@ghost ghost merged commit cc48718 into develop Aug 4, 2022
@ghost ghost deleted the dev/focus-arrow branch August 4, 2022 08:18
@jonandernovella jonandernovella mentioned this pull request Aug 8, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants