Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary success toast #541

Merged
merged 5 commits into from
Aug 4, 2022
Merged

Remove unnecessary success toast #541

merged 5 commits into from
Aug 4, 2022

Conversation

HenrikeW
Copy link
Contributor

@HenrikeW HenrikeW commented Aug 3, 2022

Related issue(s) and PR(s)

There was a success toast for saved custom names shown every time any changes were saved.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • introduced state variable that tracks if any custom name has been changed
  • when pressing "Save changes", an attempt to save custom names is only made if any custom name has changed
  • There is only one Toast message for "All changes saved", no specific one about the names.
  • If anything goes wrong in the save with either time entries or custom names, a generic failure message will be shown.

Testing

  • Try to make some changes and save

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@HenrikeW HenrikeW requested review from jonandernovella and a user August 3, 2022 09:49
@HenrikeW HenrikeW changed the title Dev/save names Remove unnecessary success toast Aug 3, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Looks reasonable!

@HenrikeW HenrikeW requested a review from a user August 3, 2022 13:09
@jonandernovella
Copy link
Contributor

Except for the bug I mentioned, it looks good!

Copy link
Contributor

@jonandernovella jonandernovella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@jonandernovella jonandernovella merged commit 8be417d into develop Aug 4, 2022
@jonandernovella jonandernovella deleted the dev/save-names branch August 4, 2022 07:51
@jonandernovella jonandernovella mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants