Advanced search #527
Merged
Advanced search #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenrikeW
reviewed
Aug 1, 2022
There was a problem hiding this comment.
Really cool feature! I think many people will love this.
I made some styling suggestions to get it a bit more in line with the rest of Urdr.
(And I ignored everything I already had seen in other PRs, looked only at the parts of the code that belonged to the Advanced search).
This fetches found issues related to the given query.
Now we use either the issues api or the search api, depending on whether the user enters a number or a string.
jonandernovella
force-pushed
the
dev/advanced-search
branch
from
ea4fdae to
929b824
Compare
They seem to be buggy.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #341
Type of change
List of changes made
Further comments
Definition of Done checklist