Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give custom names to favorite rows #526

Merged
merged 14 commits into from
Aug 2, 2022
Merged

Give custom names to favorite rows #526

merged 14 commits into from
Aug 2, 2022

Conversation

jonandernovella
Copy link
Contributor

@jonandernovella jonandernovella commented Jul 26, 2022 •
edited
Loading

Related issue(s) and PR(s)

This PR closes #224

Type of change

  • New feature (non-breaking change which adds functionality)

List of changes made

  • Updated the issue-activity display in rows with a text area so that custom names can be given to favorite issues
  • Original names are displayed on hover using a tooltip

Screenshot

bild

Testing

  • Usual procedure

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@jonandernovella jonandernovella requested a review from a team July 26, 2022 13:26
@jonandernovella jonandernovella self-assigned this Jul 26, 2022
@jonandernovella jonandernovella requested a review from jhagberg July 26, 2022 13:38
@jonandernovella jonandernovella force-pushed the dev/custom-names branch 2 times, most recently from ef8324e to 75e4ed1 Compare July 27, 2022 09:02
HenrikeW
HenrikeW reviewed Aug 1, 2022
View reviewed changes
HenrikeW
HenrikeW approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@HenrikeW HenrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@HenrikeW HenrikeW merged commit 2b7a096 into develop Aug 2, 2022
@HenrikeW HenrikeW deleted the dev/custom-names branch August 2, 2022 06:52
@jonandernovella jonandernovella mentioned this pull request Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikeW HenrikeW HenrikeW approved these changes

@jhagberg jhagberg Awaiting requested review from jhagberg

Assignees

@jonandernovella jonandernovella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let user give custom name to favorites
2 participants
@jonandernovella @HenrikeW