Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure triangle is visible on Safari #513

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Conversation

jonandernovella
Copy link
Contributor

This makes sure that the border is also visible on Safari.

Related issue(s) and PR(s)

#260

Type of change

  • Bug fix (non-breaking change which fixes an issue)

List of changes made

Updated border style to solid, instead of inset, which makes the button visible on all tested browsers.

Testing

  • Checkout this branch and test on a safari web browser.

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

This makes sure that the border is also visible on Safari.
@jonandernovella jonandernovella requested a review from a team July 4, 2022 14:26
@jonandernovella jonandernovella self-assigned this Jul 4, 2022
@HenrikeW HenrikeW merged commit e472bda into develop Jul 7, 2022
@HenrikeW HenrikeW deleted the fix/comment-btn branch July 7, 2022 12:57
@jonandernovella jonandernovella mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants