-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit help page for hidden rows #499
Conversation
starting review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last section "Hidden rows with time entries" should also be updated.
Now it says that "If you hide a row in urdr, it will be permanently hidden unless you add it again manually. " so we should add that it can seen in the hidden rows section and remove that it's forever gone.
Otherwise well done! |
I wonder whether the linter is complaining about the repetition of the
|
I agree, this could really be it. Can the two rows be more unique by adding an unique id or similar? |
Yes that was it!! Well spotted! |
Starting review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Related issue(s) and PR(s)
This PR closes #495
Type of change
List of changes made
Screenshot of the fix
Testing
Further comments
Definition of Done checklist