Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit help page for hidden rows #499

Merged
merged 10 commits into from
May 31, 2022
Merged

Conversation

HenrikeW
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #495

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • a paragraph about the hidden rows section was added to the help page
  • some other paragraphs were adjusted so that they reflect the current functionality of the page, including the hidden rows section
  • some missing component properties were added on the help page to prevent error lines

Screenshot of the fix

Testing

  • read the new parts of the help page and check if they are understandable

Further comments

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@KattisLej
Copy link
Contributor

starting review

@HenrikeW HenrikeW requested review from jonandernovella, KattisLej, a user and kusalananda May 25, 2022 12:34
Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last section "Hidden rows with time entries" should also be updated.
Now it says that "If you hide a row in urdr, it will be permanently hidden unless you add it again manually. " so we should add that it can seen in the hidden rows section and remove that it's forever gone.

@KattisLej
Copy link
Contributor

Otherwise well done!

@kusalananda
Copy link
Member

I wonder whether the linter is complaining about the repetition of the Row element:

<Row
  topic={exampleIAP}
  days={[new Date()]}
  rowHours={[1]}
  rowEntries={[exampleEntry]}
  getRowSum={() => 1}
  onToggleHide={() => {}}
  isFav={false}
  onToggleFav={() => {}}
  onCellUpdate={() => {}}
></Row>

@KattisLej
Copy link
Contributor

I wonder whether the linter is complaining about the repetition of the Row element:

<Row
  topic={exampleIAP}
  days={[new Date()]}
  rowHours={[1]}
  rowEntries={[exampleEntry]}
  getRowSum={() => 1}
  onToggleHide={() => {}}
  isFav={false}
  onToggleFav={() => {}}
  onCellUpdate={() => {}}
></Row>

I agree, this could really be it. Can the two rows be more unique by adding an unique id or similar?

@HenrikeW HenrikeW requested a review from KattisLej May 30, 2022 11:23
@HenrikeW
Copy link
Contributor Author

I wonder whether the linter is complaining about the repetition of the Row element:

<Row
  topic={exampleIAP}
  days={[new Date()]}
  rowHours={[1]}
  rowEntries={[exampleEntry]}
  getRowSum={() => 1}
  onToggleHide={() => {}}
  isFav={false}
  onToggleFav={() => {}}
  onCellUpdate={() => {}}
></Row>

Yes that was it!! Well spotted!

@KattisLej
Copy link
Contributor

Starting review

Copy link
Member

@kusalananda kusalananda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kusalananda kusalananda merged commit 44b58bd into develop May 31, 2022
@kusalananda kusalananda deleted the fix/help-page-hidden-rows branch May 31, 2022 07:13
@jonandernovella jonandernovella mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update help page with hidden rows section
3 participants