Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate hidden rows with time entries #493

Merged
1 commit merged into from
May 25, 2022
Merged

populate hidden rows with time entries #493

1 commit merged into from
May 25, 2022

Conversation

HenrikeW
Copy link
Contributor

@HenrikeW HenrikeW commented May 24, 2022

Related issue(s) and PR(s)

This PR closes #491

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • the function getAllEntries was changed to accept a single array of IssueActivityPairs (i.e. rows) as an argument
  • where it's called, the hidden rows are included in the argument array (previously, the function took two arrays as arguments, which were the recent rows and the favorite rows). The function is called on page load as well as after successful save.

Screenshot of the fix

Testing

  • go to the report page in a week that has time entries on favorite, recent and hidden rows. You should see all of them.
  • make a change in a time entry in a hidden row and save. The sum should be correct both before and after save.
  • un-hide the row you've just made a change in. It should move to the recent section together with all its entries.
  • to make sure no previous functionality broke, feel free to play around with modifying time entries and moving rows between all three sections.

Further comments

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@HenrikeW HenrikeW requested review from jonandernovella, KattisLej, kusalananda and a user May 24, 2022 14:26
Copy link
Member

@kusalananda kusalananda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to resolve the reported issues.
I'm not merging this now, though, to enable @konere10 to have a look too.

Copy link
Contributor

@KattisLej KattisLej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@ghost ghost merged commit 3e201d0 into develop May 25, 2022
@ghost ghost deleted the fix/hidden-rows branch May 25, 2022 06:14
@jonandernovella jonandernovella mentioned this pull request May 31, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hidden rows do not show time entires, do not contribute to sums
3 participants