Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section for hidden rows #490

Merged
merged 5 commits into from
May 24, 2022
Merged

Add section for hidden rows #490

merged 5 commits into from
May 24, 2022

Conversation

HenrikeW
Copy link
Contributor

@HenrikeW HenrikeW commented May 24, 2022

Related issue(s) and PR(s)

This PR closes #470

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • a section was added in which hidden rows are rendered
  • a button was added to switch between showing and not showing that section. The default is to not show it.
  • a button in each hidden row was added to move the row back to the list of recent rows
  • the functionality to toggle favorites was adjusted so that even hidden rows can become favorites in one click

Screenshot of the fix

image
image

Testing

  • Go to the report page
  • Try to toggle the hidden-section with the new button
  • If you don't have hidden rows yet, try to hide some from the recent-section
  • try to un-hide a hidden row by clicking on the double-arrow up
  • try to make a hidden row a favorite by clicking on the star
  • try to reload the page and make sure the right favorites and hidden rows are loaded. (Using the toggle icons for favorite/hide/un-hide on the left of each row should save immediately)

Further comments

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@HenrikeW HenrikeW changed the title Dev/show hidden Add section for hidden rows May 24, 2022
@HenrikeW HenrikeW requested review from jonandernovella, KattisLej, a user and kusalananda May 24, 2022 12:28
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, also with keyboard nav.
Though, somehow the "labelledby" for the day sum seems to have re-entered in this code. This should be fixed - again - before merging this code.

Copy link
Member

@kusalananda kusalananda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Looks good and works well.

@kusalananda kusalananda merged commit 9c2ac19 into develop May 24, 2022
@kusalananda kusalananda deleted the dev/show-hidden branch May 24, 2022 12:51
@jonandernovella jonandernovella mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time entries missing after use of "hide" button
2 participants