Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make total hours cells non-navigatable #487

Merged
merged 3 commits into from
May 24, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/components/Row.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,12 @@ export const Row = ({
type="text"
aria-label={`total of hours spent on the issue ${topic.issue.id}, ${topic.issue.subject}, on the activity ${topic.activity.name}`}
id={`${topic.issue.id}${topic.activity.id}-total`}
className="cell not-outline"
className="cell"
value={getRowSum(topic)}
readOnly
onFocus={onFocusRow}
onBlur={onBlurRow}
tabIndex={-1}
/>
</div>
</div>
Expand Down
4 changes: 0 additions & 4 deletions frontend/src/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -411,10 +411,6 @@ Other button classes are defined further down together with other classes for th
outline: none;
}

.not-outline {
outline: none;
}

.invalid {
border: 2px solid hsl(17deg 91% 31%);
}
Expand Down
6 changes: 4 additions & 2 deletions frontend/src/pages/Report.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -669,9 +669,10 @@ export const Report = () => {
aria-labelledby={`total of hours spent during the day ${dateStr}`}
type="text"
id={dateStr}
className="cell not-outline"
className="cell"
value={getTotalHours(dateStr)}
readOnly
tabIndex={-1}
/>
</div>
);
Expand All @@ -681,9 +682,10 @@ export const Report = () => {
<input
aria-label="total of hours spent during the week"
type="text"
className="cell not-outline"
className="cell"
value={getTotalHoursWeek()}
readOnly
tabIndex={-1}
/>
{/* Only show warnings for weeks that have passed.
It must be at least Saturday. */}
Expand Down