Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight rows on focus #486

Merged
4 commits merged into from
May 23, 2022
Merged

Highlight rows on focus #486

4 commits merged into from
May 23, 2022

Conversation

jonandernovella
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #485

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • Added on focus and on blur logic for rows
  • Fixed background of star icon

Screenshot of the fix

bild

Testing

  • Play around with selecting the inputs and comments of the rows
  • Use keyboard navigation

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@jonandernovella jonandernovella requested review from HenrikeW and a user May 23, 2022 14:20
@jonandernovella jonandernovella changed the title Dev/row selection Highlight rows on focus May 23, 2022
ghost
ghost approved these changes May 23, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ghost ghost merged commit 6f52c2e into develop May 23, 2022
@ghost ghost deleted the dev/row-selection branch May 23, 2022 14:24
@jonandernovella jonandernovella mentioned this pull request May 24, 2022
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenrikeW HenrikeW Awaiting requested review from HenrikeW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indicate active row in Urdr
1 participant
@jonandernovella