Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete www-authenticate header from login response #481

Merged
merged 1 commit into from
May 23, 2022
Merged

Conversation

jonandernovella
Copy link
Contributor

This makes sure that the basic auth popup is no longer shown by the browser.

Related issue(s) and PR(s)

This PR closes #475

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

List of changes made

  • The header that was being used by Chrome to display the auth pop-up has now been dropped from our server's http response.

Screenshot of the fix

Testing

  • Attempt to log in with invalid creds on Chrome

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

This makes sure that the basic auth popup is no longer shown by the browser.
@jonandernovella jonandernovella requested review from kusalananda and a user May 23, 2022 07:42
Copy link
Member

@kusalananda kusalananda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@kusalananda kusalananda merged commit 2a9f3c7 into develop May 23, 2022
@kusalananda kusalananda deleted the fix/pop-up branch May 23, 2022 07:51
@jonandernovella jonandernovella mentioned this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behaviour upon invalid login credentials
2 participants