Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop users from browsing to nagative years #477

Merged
merged 1 commit into from
May 20, 2022

Conversation

jonandernovella
Copy link
Contributor

Related issue(s) and PR(s)

This PR closes #476

Type of change

  • Bug fix (non-breaking change which fixes an issue)

List of changes made

The case of entering a negative year has now been handled.

Testing

  • Navigate to a year with a negative number.

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Tests and lint/format validations are passing
  • My changes generate no new warnings

@jonandernovella jonandernovella requested review from HenrikeW and a user May 20, 2022 12:41
ghost
ghost previously requested changes May 20, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are to check this, we should require year to be > 1900 since "0" for year will result in year 1900.

@jonandernovella jonandernovella requested a review from a user May 20, 2022 13:00
@jonandernovella
Copy link
Contributor Author

If we are to check this, we should require year to be > 1900 since "0" for year will result in year 1900.

That was not part of this bug report. Feel free to make a new one!

@jonandernovella jonandernovella dismissed ghost ’s stale review May 20, 2022 13:04

See comments.

@jonandernovella jonandernovella merged commit 5810f7b into develop May 20, 2022
@jonandernovella jonandernovella deleted the dev/validate-year branch May 20, 2022 13:04
@jonandernovella jonandernovella mentioned this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when entering a negative year number
2 participants